Conversation
Sync effect tracked saving() as well as props.value, so a finished save re-ran it with the stale prop and clobbered the just-committed value: the checkbox flicked back unchecked until a page reload. Effect now fires only when props.value changes. Failed saves also left the DOM checkbox out of sync with the committed value; onChange now snaps it back and lets a successful save re-check it via signal.
github-actions
Bot
changed the title
Spinner rendered inline next to the checkbox/select, so in the right-aligned cell it pushed the control ~18px left while a save was in flight and snapped back on completion. Spinner is now absolutely positioned outside the layout flow; controls stay put during saves.
github-actions
Bot
changed the title
Spinner mounted beside the control flashed on fast LAN saves and read as a rendering artifact next to the checkbox. Saving feedback is now the control itself greyed out (disabled at 40% opacity) with a Saving... tooltip; nothing mounts or unmounts around it.
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's fixed: