Future method consistency

[teunbrand]

Hi there,

We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
This PR silences a S3 method consistency warning we found during this check.

You can test your code with the development version of ggplot2 by installing it as follows:

# install.packages("pak")
pak::pak("tidyverse/ggplot2")

We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time or let us know when ggplot2 should change. Hopefully this will inform you in a timely manner.

Best wishes,
Teun

[arcresu]

Thanks Teun! I added an extra commit above to fix the generic compatibility for ggplot_gtable. I'll push a new release to CRAN in the next few days (#3).

Cheers,
Carl

[teunbrand]

Great, thank you!

[arcresu]

Hi @teunbrand, perhaps I misunderstood how this is supposed to work, but CRAN won't take the new version because it fails the S3 method consistency check against the current version of ggplot2 in the archive. They say to wait until ggplot2 is updated and add a versioned dependency on that.

[teunbrand]

OK this may have been a misunderstanding on my part then, thank you for circling back!

[arcresu]

In the submission I explained the reason for the change, that it was coordinated, and that the new ggplot was expected soon. For reference, here's the message I received:

Then pls submit once the new ggplot2 has been submitted or make sure
your package works with all ggplot2 versions.

Apparently you failed to add a version dependency on ggplot2 or forgot
to check it?

It's not clear if they mean that they want ggplot2 and its dependencies in the submission queue at the same time, or if they'll let through ggplot2 even with the revdep check failures and those can be fixed separately afterward.

[teunbrand]

they'll let through ggplot2 even with the revdep check failures

I think this would be the plan, as it is impossible to coordinate among all reverse dependency maintainers. I think the version dependency they mention would just be ggplot2 (>= 4.0.0) in the description file.