Skip to content

fix: use checked arithmetic for cumulative gas accounting in payload builder #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himess wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

fix: use checked arithmetic for cumulative gas accounting in payload builder #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae0f2a
fix: use checked arithmetic for cumulative gas accounting in payload …
Himess Apr 11, 2026
4755edd
fix: replace saturating_add with checked_add + error propagation per …
Himess Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/execution-payload/src/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ where
let chain_spec = client.chain_spec();

info!(target: "payload_builder", id=%attributes.id, parent_header = ?parent_header.hash(), parent_number = parent_header.number, "(arc) building new payload");
let mut cumulative_gas_used = 0;
let mut cumulative_gas_used: u64 = 0;
let block_gas_limit: u64 = builder.evm_mut().block().gas_limit();
let base_fee = builder.evm_mut().block().basefee();

Expand Down Expand Up @@ -576,7 +576,7 @@ where
}

// ensure we still have capacity for this transaction
if cumulative_gas_used + pool_tx.gas_limit() > block_gas_limit {
if cumulative_gas_used.checked_add(pool_tx.gas_limit()).is_none_or(|total| total > block_gas_limit) {
// we can't fit this transaction into the block, so we need to mark it as invalid
// which also removes all dependent transaction from the iterator before we can
// continue
Expand Down Expand Up @@ -657,7 +657,13 @@ where
.effective_tip_per_gas(base_fee)
.expect("fee is always valid; execution succeeded");
total_fees += U256::from(miner_fee) * U256::from(gas_used);
cumulative_gas_used += gas_used;
cumulative_gas_used = cumulative_gas_used
.checked_add(gas_used)
.ok_or_else(|| {
PayloadBuilderError::other(eyre::eyre!(
"cumulative_gas_used overflow: {cumulative_gas_used} + {gas_used}"
))
})?;
}

PayloadBuildMetrics::record_stage_tx_execution(loop_started.elapsed());
Expand Down