Skip to content

feat(sync): Add eager status update mode for sync actor#1452

Merged
romac merged 15 commits intocirclefin:mainfrom
romac:sync/eager-status-update
Feb 17, 2026
Merged

feat(sync): Add eager status update mode for sync actor#1452
romac merged 15 commits intocirclefin:mainfrom
romac:sync/eager-status-update

Conversation

@romac
Copy link
Copy Markdown
Contributor

@romac romac commented Feb 4, 2026

Summary

Introduces a new status update mode that sends a status update as soon as a new height is started rather than at fixed intervals.

To enable this mode, set status_update_interval = 0.

Testing

For testing in Arc, use my eager-sync-updates branch

@romac romac force-pushed the sync/eager-status-update branch 2 times, most recently from 7cdd6bd to ef6eb64 Compare February 5, 2026 09:08
romac added 5 commits February 5, 2026 09:09
Introduces a new status update mode that sends updates only upon decisions
rather than at fixed intervals. When `status_update_interval` is set to zero,
the sync actor switches to `OnDecision` mode, triggering status updates after
each decision with a small random jitter (0-50ms) to avoid thundering herd problems.
@romac romac force-pushed the sync/eager-status-update branch from ef6eb64 to 9df917f Compare February 5, 2026 09:09
Copy link
Copy Markdown
Contributor

@cason cason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments about advertising intervals.

Comment thread code/crates/engine/src/sync.rs
Comment thread code/crates/engine/src/sync.rs
Comment thread code/crates/engine/src/sync.rs Outdated
@romac romac force-pushed the sync/eager-status-update branch from 4084073 to e0939bd Compare February 6, 2026 09:59
Comment thread code/crates/engine/src/sync.rs Outdated
Comment thread code/crates/sync/src/handle.rs Outdated
@romac romac marked this pull request as ready for review February 10, 2026 09:43
@romac romac requested a review from cason February 10, 2026 09:43
@romac romac added the sync Synchronization protocols label Feb 10, 2026
@romac romac requested a review from ancazamfir February 16, 2026 09:21
Comment thread code/crates/engine/src/sync.rs Outdated
@romac romac requested a review from ancazamfir February 16, 2026 12:02
Copy link
Copy Markdown
Contributor

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm!

@romac romac added this pull request to the merge queue Feb 17, 2026
Merged via the queue into circlefin:main with commit df5901d Feb 17, 2026
16 checks passed
@romac romac deleted the sync/eager-status-update branch February 17, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync Synchronization protocols

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants