[ONCR-1126] StableFX Settlement Advance#453
Merged
yitianx00 merged 3 commits intoJun 29, 2026
Merged
Conversation
yitianx00
reviewed
Jun 29, 2026
| // Keys within public, will be also exposed to the client-side | ||
| public: { | ||
| baseUrl: process.env.BASE_URL || 'https://api-sandbox.circle.com', | ||
| baseUrl: process.env.BASE_URL || 'https://api-smokebox.circle.com', |
Contributor
There was a problem hiding this comment.
Is this change intended?
Contributor
Author
There was a problem hiding this comment.
No - that's my b
Add debug pages for the nine StableFX settlement advance endpoints: get credit line, reserve, cancel reservation, presign, request, get by ID, list, repay, and get repayment. Presign and request follow the existing trade signing flow, generating the Permit2 signature via Developer Controlled Wallets (Sign With Circle). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Re-add a recipientAddress input to the trade presign page and send it as
a required query param on GET /v1/exchange/stablefx/signatures/presign/{tradeId}.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a "Proceed to Settlement Advance" button on the trade signature page that navigates to the settlement advance presign page with the tradeId. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bchow-circle
force-pushed
the
feat/stablefx-settlement-advance
branch
from
June 29, 2026 21:10
a8f5525 to
54539e7
Compare
yitianx00
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Went through E2E flow for an advance