refactor: pluralize StableFX Settlement Advance API paths#454
Merged
anilgangapersaud-circle merged 2 commits intoJun 30, 2026
Merged
Conversation
Mirrors wallets-api#3485, which pluralizes the StableFX Settlement
Advance external collection resources per REST convention. Updates the
sample app's outbound request paths in lockstep.
- /settlementAdvance -> /settlementAdvances (list/create/by-id)
- .../reservation/{id}/cancel -> .../reservations/{id}/cancel
- /signatures/settlementAdvance/presign -> /signatures/settlementAdvances/presign
- .../repayment -> .../repayments (create + by-id)
/credit and the reserve/cancel verb sub-paths are unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
anilgangapersaud-circle
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors wallets-api#3485, which pluralizes the StableFX Settlement Advance external collection resources per REST convention. Updates the sample app's outbound request paths in
lib/stablefxTradesApi.tsin lockstep./settlementAdvance/settlementAdvancesGET /{advanceId}…/reservation/{id}/cancel…/reservations/{id}/cancel/signatures/settlementAdvance/presign/signatures/settlementAdvances/presign…/repayment…/repayments…/creditVerb sub-paths (
reserve,cancel) are unchanged. The/debug/stablefx/settlementAdvance/...Nuxt page routes are local frontend paths, not backend API calls, so they are left as-is.Test plan
BASE_URL=https://api-smokebox.circle.com— exercise SA flows against smokebox🤖 Generated with Claude Code