feat: support additional currencies HKD, CNH, and SGD #457
Merged
anilgangapersaud-circle merged 1 commit intoJul 3, 2026
Conversation
anilgangapersaud-circle
approved these changes
Jul 3, 2026
qhou
changed the title
qhou
force-pushed
the
codex/add-sgd-legacy-trades
branch
from
July 3, 2026 18:14
fede133 to
6b4a5fa
Compare
qhou
force-pushed
the
codex/add-sgd-legacy-trades
branch
from
July 3, 2026 18:17
6b4a5fa to
17e0ff0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HKD,CNH, andSGDto the legacy trades quote debug screen, flow debug screenHKD,CNH, andSGDto the legacy trades settlements fetch and instructions screensThis follows the same lightweight currency-enable pattern as #456, but for the legacy trades screens instead of StableFX.
Test plan
/debug/trades/quoteand verifyHKD,CNH, andSGDappear in the currency options/debug/trades/flowand verify each currency can be used to complete the trade flow successfullyHKDCNHSGDValidation
Validated locally in the sample app with successful trade flow submissions for all three currencies: