Add support for TF command (FileAttribute) from GerberX2

[shane-circuithub]

No description provided.

[shane-circuithub]

This is completely untested right now, but I'm interested to see if either of you have any comments on the work so far before I go any further with it.

[HanStolpo]

This looks really good and clean great work, I only have question about using the TH constructor for "NPTH" attributes which I think should change, and then maybe we can add a round trip test to see that we can parse what we print, that is if we have a print for the gerber commands.

[HanStolpo]

why don't we have a distinct constructor for non plated through hole, I feel we are loosing vital information here, also you won't be able to print what you parse

[shane-circuithub]

I drop that information because it's redundant, and it allows me to use the same record for both the fields of both Plated and NonPlated. Here's the relevant part of the spec

[HanStolpo]

👍

[HanStolpo]

I see we don't have a printGerber to go with the parseGerber, so ignore my comment about a round trip test, we should probably add that in a future enhancement, especially when we want to convert Excellon Drill files to Gerber X2 files at a later stage.

[ocharles]

All seems good to me! Just one suggestion - and I also agree with Handre's comment.

[ocharles]

You aren't actually checking both conditions of this error, which I think might lead to confusion later. I suggest we either do check that the digits are hexadecimal, or just drop this from the error message.

[shane-circuithub]

I am checking the condition. If they weren't hexadecimal digits then decode (from base16-bytestring) would fail.

[shane-circuithub]

Or at least wouldn't return 16 bytes of data with nothing leftover.

[ocharles]

Ah sorry, I missed the call to decode. Great!

[ocharles]

I see we don't have a printGerber to go with the parseGerber, so ignore my comment about a round trip test, we should probably add that in a future enhancement, especially when we want to convert Excellon Drill files to Gerber X2 files at a later stage.

I wouldn't ignore this comment, it's a fundamental architectural choice of the parser to try and faithfully parse the input into a data structure as close as possible to the input.