Update confusing Rel8.Table.bool docs.#391
Merged
TeofilC merged 1 commit intocircuithub:masterfrom Oct 16, 2025
Merged
Conversation
TheOddler
commented
Oct 16, 2025
|
|
||
|
|
||
| -- | An if-then-else expression on tables. | ||
| -- | Case analysis for an @Expr Bool@. Corresponds to 'Data.Bool.bool'. |
Contributor
Author
There was a problem hiding this comment.
Using the wording "Case analysis" from the description of Data.Bool.Bool, and the "Corresponding to ..." from the description of Rel8.Expr.Bool.boolExpr. Sound OK I guess?
Contributor
|
Thanks this is a lot clearer! |
TeofilC
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the description that mentions
if-then-elsewhile it's more like aif-NOT-then-elseconfusing. So thought it better that it actually mentionsData.Bool.boolas it's mirroring that.I wonder, is it also worth adding an actual
ifThenElse = flip boolfunction, might be more intuitive?