"Simple" Profile configuration#49
Merged
t-unit merged 2 commits intocircus-kitchens:mainfrom Apr 17, 2024
Merged
Conversation
…s from the official data wedge api
Contributor
|
Thank you very much for your contribution :) |
t-unit
approved these changes
Apr 17, 2024
Contributor
|
Your changes got released with version v3.1.0-dev.1 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have seen this pull request #26. With the assumption that it might take time to implement the modifications and requested dependencies (Pingeon), i took the opportunity to make a smaller adjustment to update existing data wedge profiles.
The implementation has no checks and assumes that the user knows the parameters to be set. However, I can also understand if this implementation is not user-friendly and get rejected.