Skip to content

softnet, tart: nest versioned depends_on macos in on_macos block#15

Closed
Aayush9029 wants to merge 1 commit into
cirruslabs:masterfrom
Aayush9029:nest-depends-on-macos
Closed

softnet, tart: nest versioned depends_on macos in on_macos block#15
Aayush9029 wants to merge 1 commit into
cirruslabs:masterfrom
Aayush9029:nest-depends-on-macos

Conversation

@Aayush9029

Copy link
Copy Markdown

Every brew command emits a deprecation warning for softnet and tart:

Warning: Calling `depends_on :macos` with `depends_on macos:` is
deprecated! Use `depends_on :macos` with `depends_on macos:` inside
an `on_macos` block instead.
  softnet.rb:18 / tart.rb:22

This wraps the versioned depends_on :macos => :sequoia / :ventura in an
on_macos block as Homebrew now requires, silencing the warning. No behavior
change.

Since these formulas are generated by GoReleaser, companion PRs fix the
custom_block in each source repo's .goreleaser.yml so future releases
regenerate correctly: cirruslabs/softnet and cirruslabs/tart.

@romualdoag romualdoag left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wincent

wincent commented Jun 16, 2026

Copy link
Copy Markdown

tart PR got merged upstream:

So presumably that will get synced over automatically after the next release (most recent release was 2.32.1, on 2026-04-12).

Still waiting for softnet PR to be merged:

@Aayush9029 Aayush9029 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants