Skip to content

3506 - Resolve Terraform vulnerabilities#1518

Open
jayjaybunce wants to merge 5 commits into
developfrom
jb-crasm-3506
Open

3506 - Resolve Terraform vulnerabilities#1518
jayjaybunce wants to merge 5 commits into
developfrom
jb-crasm-3506

Conversation

@jayjaybunce

Copy link
Copy Markdown
Contributor

🗣 Description

Removed email-sender.tf and pe-worker.tf. Both files controlled resources that we no longer used and contained vulnerable configuration. Rather than fix the configuration, the resources will be removed.

Updated pe_worker.tf to remove the pe_worker EC2 instance, iam roles and policies.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

aloftus23
aloftus23 previously approved these changes Jul 1, 2026

@aloftus23 aloftus23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the terraform plan and this looks good to me. On the very small chance this affects P&E operations, maybe we should wait to merge until after they send out their reports today. What do you think @rapidray12 @cduhn17 ?

@jayjaybunce

Copy link
Copy Markdown
Contributor Author

Reviewed the terraform plan and this looks good to me. On the very small chance this affects P&E operations, maybe we should wait to merge until after they send out their reports today. What do you think @rapidray12 @cduhn17 ?

If reports have been sent out already, can we get this merged? @cduhn17 @rapidray12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants