Fix/proto rate comment drift - #5
Merged
Merged
Conversation
The proto copies in this repo had drifted from the backend's: they described Rate.scale as "typically 86400 (per day)" where the backend says 3600 (per hour). mapping.RatePerHour is the only Rate constructor server-side and always sets Scale: 3600, so the backend wording is the correct one. Sync proto/cityio/ from the backend tree and carry the corrected text into the generated TypeScript. Comment-only: no descriptor or wire change. ratePerHour() already divided by the actual scale field, so displayed values were never affected. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The proto layout moved to entity/v1 + service/v1 packages, but CLAUDE.md still described a single proto/cityio/v1/ directory and told readers to copy from ../cityio-backend/, a path that does not exist (the sibling checkout is ../backend/). Update both, add the diff -r sync check to the regeneration steps, and note that a missing buf CLI fails loudly while leaving generated code describing the old contract. Also list tiles.ts, rates.ts and session.ts in the structure tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.