feat(domain): add domain record update command#592
Open
giornetta wants to merge 3 commits into
Open
Conversation
Implements `civo domain record update DOMAIN/DOMAIN_ID RECORD_ID` so records can be modified in place instead of remove-and-recreate. Only flags the user passes are changed; other fields keep their current values. Closes #386
Add a shared dnsRecordOutputWriter helper so show, create and update emit the full record field set in json/custom. Fixes create outputting the domain's id/name instead of the record's, fixes show using WriteMultipleObjectsJSON and missing the NS type case, and uppercases the record type consistently in list, create and update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #386
New:
civo domain record updateAdds
civo domain record update DOMAIN/DOMAIN_ID RECORD_ID [flags]so DNS records can be modified in place rather than the remove-and-recreate workaround. Wraps civogo'sUpdateDNSRecord(PUT /v2/dns/{domain_id}/records/{record_id}).Flags mirror
record create:--name/-n,--value/-v,--type/-e,--ttl/-t,--priority/-p. The existing record is fetched first and only the flags actually passed are overridden, so unspecified fields keep their current values (the API call is a full-replace PUT).Output consistency across domain commands
While here, made json/custom output consistent across the record commands via a shared
dnsRecordOutputWriterhelper:WriteMultipleObjectsJSONfor a single object (nowWriteSingleObjectJSON) and its type if-chain silently dropped NS records — both fixed.