Add region bounds checks#1
Open
dnadlinger wants to merge 5 commits intocjbe:masterfrom
Open
Conversation
This was an uncommitted change on hoa2mstr; unclear who made it and when.
Failures in the initial camera configuration during startup would be masked by AttributeErrors etc. previously.
It is amazing that this apparently worked for the longest time; the mismatch in type sizes made the behaviour dependent on the stack environment. This caused what appeared to be random breakage depending on the exact Python version/binary used (e.g. in Nix vs. system Python); for the riveting conclusion (incl. reverse engineering libandor.so to locate a hidden debug log option).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an uncommitted change on hoa2mstr; unclear who made it and when.