Fixed annminer bug/feature that would prevent announcements with lower height than previous batch from being sent to handler#60
Open
UCIS wants to merge 1 commit intocjdelisle:developfrom
Conversation
…r height than previous batch from being sent to handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes an old feature in the announcement miner that would drop announcement batches with a height lower than the previous batch sent to that same handler. This feature prevents mining pools from dynamically altering the mineOld setting as a way to optimize their announcement set, possibly complicating recovery from a chain stall when insufficient mature announcements are available.
A quick test did not show side effects other than the intended behavior. Since all mining threads are halted for mining work changes, and the announcement are placed directly in a queue in the miner callback, there should be no reordering issues between miner threads, out-of-order announcements would only appear as a result of changed mining instructions from the pool.