Skip to content

Add RAF cleanup to Manuals.tsx scroll listener #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: perf/optimize-manuals-scroll-10061944444742086940
Choose a base branch
from
Draft

Add RAF cleanup to Manuals.tsx scroll listener #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3938fe2
Initial plan
Copilot Feb 4, 2026
78682e4
Add RAF cleanup to prevent updates after unmount
Copilot Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 17 additions & 26 deletions src/pages/products/Manuals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,34 +44,19 @@ export default function Landing() {
const container = document.getElementById('landing-container');
if (!container) return;

let ticking = false;
let rafId: number | null = null;

const handleScroll = () => {
if (!ticking) {
window.requestAnimationFrame(() => {
const scrollTop = container.scrollTop;

setScrollY((prev) => {
// Optimization: Stop updating state once the hero section is fully hidden (opacity reaches 0 at 600px).
// This prevents unnecessary re-renders when scrolling through the rest of the page.
if (prev > 600 && scrollTop > 600) {
return prev;
}
return scrollTop;
});

ticking = false;
});
ticking = true;
}
};

container.addEventListener('scroll', handleScroll, { passive: true });
return () => container.removeEventListener('scroll', handleScroll);
}, []);
const update = () => {
const scrollTop = container.scrollTop;

// Optimization: Stop updating once the hero section is fully hidden (opacity reaches 0 at 600px).
// This prevents unnecessary updates when scrolling through the rest of the page.
if (scrollTop > 600) {
ticking.current = false;
rafId = null;
return;
}

const heroOpacity = Math.max(0, 1 - scrollTop / 600);
const heroScale = 1 + scrollTop * 0.0002;

Expand All @@ -83,11 +68,12 @@ export default function Landing() {
}

ticking.current = false;
rafId = null;
};

const handleScroll = () => {
if (!ticking.current) {
window.requestAnimationFrame(update);
rafId = window.requestAnimationFrame(update);
ticking.current = true;
}
};
Expand All @@ -96,7 +82,12 @@ export default function Landing() {
update();

container.addEventListener('scroll', handleScroll, { passive: true });
return () => container.removeEventListener('scroll', handleScroll);
return () => {
container.removeEventListener('scroll', handleScroll);
if (rafId !== null) {
cancelAnimationFrame(rafId);
}
};
}, []);

return (
Expand Down