This repository was archived by the owner on Jul 3, 2018. It is now read-only.
Pick the nearest element in the direction of scrolling#5
Open
frankier wants to merge 1 commit into
Open
Conversation
Owner
|
While I agree with the behaviour, there is a bug that prevents one from scrolling back to the previous element, when using snap-coords. Reproduce: Expected: snap to element 1. @frankier: do you want to fix it yourself? |
Author
|
Hi, I'm probably not going to fix this since my fix works fine for my own purpose. Please just treat this PR as a bug report in that case. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this behaviour is best generally. When compared to Firefox's implementation, Firefox will always scroll to the next in the direction if you press a button on the scrollbar, but if you drag it will snap to the current nearest. In our case, we can't tell which happened, so I think going to the nearest in the direction of scrolling is a reasonable option.