chore(lr-5e24): static ESM import-resolution check for lib/public/#227
Merged
Conversation
Adds test/esm-import-check.test.js — a static analysis pass that walks every .js file in lib/public/, extracts named imports from relative specifiers, and verifies that each imported name is actually exported by the target module. Catches the failure class from lr-8657 / PR #223: stale named imports that point to a file where the export has moved or been renamed. All 276 existing unit tests pass; the new check adds test #277 and runs in under 2 ms. Constraints honoured: - Static only: no dynamic require/import, no browser code execution. - Skips bare specifiers (node:*, ws, …). - Skips export * chains to avoid false-positives on unbounded re-exports. - Zero new npm dependencies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is checked
What is intentionally skipped
Test plan
Regression proof
A stale import { getPendingNavigate } from ./filebrowser.js (after the export moved to pending-navigate.js) would produce:
MISSING EXPORT app.js imports { getPendingNavigate } from ./modules/filebrowser.js — not exported by modules/filebrowser.js
Task: lr-5e24