Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors backend method execution so that the backend method to be executed is defined in service call metadata rather than only in backend configuration, and ties backend methods to class definitions.
Changes:
- Add
ClassMapper.get_class_properties()and refactorServiceMapperto resolve and invoke a singleSYSBackendMethoddefined in service call metadata after mapping is complete. - Remove legacy
SYSBackendMethodsconfiguration from PKI service properties and instead specifySYSBackendMethodper call inservice_call_metadata.py. - Minor cleanup in
ClassHandler.set_json_dictto keep system keys out of generated JSON.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/microesb.py | Adds get_class_properties, refactors ServiceMapper.__init__ to drive backend method execution from call metadata, and adjusts JSON generation behavior. |
| example/02-pki-management/service_properties.py | Removes obsolete SYSBackendMethods list; keeps only property and method declarations on classes. |
| example/02-pki-management/service_call_metadata.py | Declares SYSBackendMethod in each service call item to select which backend method to run for each PKI-related service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@clauspruefer I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Backend Method Processing logic is sub-optimal / needs refactoring.
Why
Related Issue
Fixes #39
Type of Change