fix(deps): migrate off react-router-dom to react-router v8 (security) - #24
Merged
Merged
Conversation
react-router-dom never received a v8 release; react-router 8.3.0 now ships the DOM bindings directly. Bump react/react-dom to 19.2.8 (react-router v8 peer requirement) and update all imports from 'react-router-dom' to 'react-router'. Fixes Dependabot alert #9 (high severity): RSC mode CSRF bypass allowing action execution before a 400 response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-router-domnever received a v8 release;react-router8.3.0 now ships the DOM bindings directlyreact-router-dom, installreact-router@8.3.0react/react-domto 19.2.8 (react-router v8 peer requirement)frontend/srcfromreact-router-domtoreact-routerNote
react-router@8.3.0declares an engine requirement of Node >=22.22.0. Local dev showed an EBADENGINE warning on Node 22.17.0 (non-fatal); CI pinsnode-version: "22"which resolves to the latest 22.x patch, so this should be fine, but worth a build-log check on this PR.Test plan
tsc --noEmitcleannpm run buildsucceeds