Skip to content

Unified sensor#84

Open
lefty01 wants to merge 17 commits intoclaws:masterfrom
lefty01:unified-sensor
Open

Unified sensor#84
lefty01 wants to merge 17 commits intoclaws:masterfrom
lefty01:unified-sensor

Conversation

@lefty01
Copy link

@lefty01 lefty01 commented Aug 7, 2022

maybe you want to add the adafruit unified sensor api as well ... I found it quiet useful.

@coelner
Copy link
Contributor

coelner commented Nov 25, 2022

This should be separated into its own class. Otherwise everyone has to use adafruit unified sensor api in their compile chain. Even if you do not need them, it will use space.

@lefty01
Copy link
Author

lefty01 commented Nov 29, 2022

ok ... good point, let me see if I can rework it.
but would you accept some additional class here within this repo. eg. BH1750_Unified or something? Too me sounds like having a separate library module (repository bases on this one) might then be more appropriate ... but still with some name suffix?

@coelner
Copy link
Contributor

coelner commented Nov 29, 2022

Well it is @claws library, not mine.
I'm not sure, if there is a nice way. I'm definitely not into good c++ development, but I guess it could be done like this more or less: https://github.com/finitespace/BME280/blob/master/src/BME280I2C_BRZO.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants