feat: add cypherQuery as a label in the metrics#72
Open
jmbass wants to merge 1 commit intoclems4ever:masterfrom
Open
feat: add cypherQuery as a label in the metrics#72jmbass wants to merge 1 commit intoclems4ever:masterfrom
jmbass wants to merge 1 commit intoclems4ever:masterfrom
Conversation
Collaborator
jmbass
commented
Jun 2, 2022
jmbass
commented
- Adds the cypher query as a label of the execution time observation.
- Adds the cypher query as a label of the execution time observation.
clems4ever
requested changes
Jun 17, 2022
Owner
clems4ever
left a comment
clems4ever
left a comment
There was a problem hiding this comment.
With this you risk to grow a lot the number of metrics in prometheus and blow it up. I would not advise it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.