engine: add force index to joins#77
Open
ShimmerGlass wants to merge 1 commit intoclems4ever:masterfrom
Open
Conversation
innodb sometimes selects a query plan order that is not optimized. we force the indexes used to remedy that
jmbass
approved these changes
Jun 13, 2022
Collaborator
jmbass
left a comment
jmbass
left a comment
There was a problem hiding this comment.
LGTM but I'd still like to benchmark this on a future PR.
You removed redundant indexes from the DB in this PR, so we might not need to force them any longer.
clems4ever
approved these changes
Jun 17, 2022
Owner
clems4ever
left a comment
clems4ever
left a comment
There was a problem hiding this comment.
I did not know that we could force an index. Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
innodb sometimes selects a query plan order that is not optimized. we
force the indexes used to remedy that