Use openssl random serial for certs#31
Open
ruimarinho wants to merge 1 commit intoclemtibs:masterfrom
Open
Conversation
|
@ruimarinho I'm curious and forgive my ignorance, but does this improve security? To avoid disclosing information regarding the serials? Improve reliability through avoiding collisions? |
Contributor
Author
|
@holmboe I think this was simply moving the responsibility of managing the serials to openssl, nothing else. I am not aware of any security implication of the current behaviour (before merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL provides a secure built-in way of generating random serials for certificates, which avoids possible conflicts.