Skip to content

feat(localizations): translate oauthConsent section to Japanese#9028

Open
greymoth-jp wants to merge 1 commit into
clerk:mainfrom
greymoth-jp:feat/ja-oauthconsent
Open

feat(localizations): translate oauthConsent section to Japanese#9028
greymoth-jp wants to merge 1 commit into
clerk:mainfrom
greymoth-jp:feat/ja-oauthconsent

Conversation

@greymoth-jp

@greymoth-jp greymoth-jp commented Jun 28, 2026

Copy link
Copy Markdown

Description

Fills the 10 oauthConsent keys in ja-JP that were undefined and falling back to English. Scoped to that one self-contained section — the placeholders ({{applicationName}}, {{domainAction}}, {{identifier}}) and the leading space in offlineAccessNotice match en-US. Changeset included.

Type of change

  • other: localization (ja-JP)

Summary by CodeRabbit

  • New Features
    • Added Japanese text for the OAuth consent screen, so users can see the full experience in Japanese instead of falling back to English.
    • Localized key consent actions, notices, scope details, redirect messaging, and trust warnings for a more complete translation.

@changeset-bot

changeset-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8bf4f39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

@greymoth-jp is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ff22fdf8-fede-494a-87f7-21c832b44870

📥 Commits

Reviewing files that changed from the base of the PR and between de70b28 and 8bf4f39.

📒 Files selected for processing (2)
  • .changeset/ja-jp-oauthconsent.md
  • packages/localizations/src/ja-JP.ts

📝 Walkthrough

Walkthrough

Adds Japanese (ja-JP) translations for the apiKeys.oauthConsent localization keys that were previously undefined, and includes a patch changeset entry for @clerk/localizations.

Changes

ja-JP OAuth Consent Localization

Layer / File(s) Summary
oauthConsent translations and changeset
packages/localizations/src/ja-JP.ts, .changeset/ja-jp-oauthconsent.md
Populates previously undefined oauthConsent keys under apiKeys with Japanese strings for allow/deny actions, offline access notice, redirect text, redirect-URL modal, scope list title, consent subtitle, view-full-URL action, and trust warning; adds matching patch changeset entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 Kanji and kana, now in their place,
The consent screen speaks with Japanese grace.
Allow and deny, trust warnings too—
No more English fallback sneaking through!
Hop hop, localization is due! 🌸

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: translating the oauthConsent section into Japanese.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant