Support Python 3.12 and pip 23.2.1#276
Closed
fghaas wants to merge 2 commits into
Closed
Conversation
added 2 commits
December 20, 2023 12:35
We previously made use of the pkg_resources module to determine the package version (as defined by setuptools-scm) in __about__.py. This module is included in setuptools, which as of Python 3.12 has been unbundled from Python, which means it is no longer installed by default in a freshly initialized venv. There are multiple ways to address this, one being to include setuptools in the install_requires list for Python 3.12 and later. Another, also listed in the Python Packaging User Guide, is to instead use importlib.metadata.version. Since this approach works for all Python versions we intend to support (that is, from 3.8 forward), this is the better solution. Thus, refactor __init__.py to use importlib, and add Python 3.12 to the test matrix. For this to work correctly, we also need to (finally) allow a version of setuptools-scm>=6 in setup.py. Reference: https://packaging.python.org/en/latest/guides/single-sourcing-package-version/
As of Open edX Quince/Tutor 17, the Tutor Dockerfile installs pip 23.2.1. Update the GitHub Actions workflow matrix to ensure that our dependencies don't break with that pip version.
Contributor
Author
|
Closing. Superseded by #282. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.