Open
Conversation
This fixes the case where justdoit has previously been used on a disk before, where /dev/sda3 may contain an existing ZFS member signature/label for example. This would usually have to be cleared by zpool clearlabel, but passing -f to zpool create also works ``` > + zpool create -o ashift=12 -o altroot=/mnt tank /dev/sda3 > invalid vdev specification > use '-f' to override the following errors: > /dev/sda3 is part of potentially active pool 'tank' ```
Without this, ext4 would always be used, even if uefi is true, which is incorrect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
justdoit: set bootType to vfat if uefi is true
Without this, ext4 would always be used, even if uefi is true, which is incorrect
justdoit: set -f on zpool create
This fixes the case where justdoit has previously been used on a disk before, where /dev/sda3 may contain an existing ZFS member signature/label for example. This would usually have to be cleared by zpool clearlabel, but passing -f to zpool create also works