Allow module to be directly required

[Uzume]

Allow module to be directly required without needing a replace directive.

This directly affects cli/cli#1389.

For reference, it might be good to consider pushing this type of thing upstream, e.g., shurcooL#53.

[mislav]

Thanks for the suggestion!

[mislav]

By just doing this one-line change, is the cli/cli project that depends on this fork now immediately go-getable? Wouldn't we need to also replace every github.com/shurcooL/graphql import directive in this fork with ithub.com/cli/shurcooL-graphql?

[Uzume]

I believe so, yes. I did a quick code search and beyond the go.mod there only seem to be a few references:

• cli/cli/pkg/cmd/release/list/http.go
• cli/cli/pkg/cmd/gist/list/http.go
• cli/cli/api/client.go

That said, some of its other dependencies also refer to the same thing:

• shurcooL/githubv4/githubv4.go
• shurcooL/githubv4/scalar.go
• shurcooL/githubv4/gen.go

So perhaps such a change would not work without further forking that as well (however that module is even smaller than this one).

The political approach is to push for these:

• updated to modules shurcooL/graphql#53
• Add support for named GraphQL operations shurcooL/graphql#57

I am not sure how long that would take though (especially since they both seem to have bogus failures in their CI).

[Uzume]

@mislav It is too bad you cannot directly refer to shurcooL/graphql@a4a48d3 in go.mod with a line like:

       github.com/shurcooL/graphql v0.0.0-20200728183420-a4a48d3af0f4

I tried this and make just complained with an invalid version: unknown revision error.

[samcoe]

Going to close this as #3 will address this and allow the module to be required.