Add defines for the block and digest sizes.#16
Open
sadiepowell wants to merge 1 commit intoclibs:masterfrom
Open
Add defines for the block and digest sizes.#16sadiepowell wants to merge 1 commit intoclibs:masterfrom
sadiepowell wants to merge 1 commit intoclibs:masterfrom
Conversation
Having a define for this helps avoid security and other issues that can appear when using magic numbers. This mimics the behaviour seen in other libraries like Olivier Gay's excellent SHA-2 library.
jwerle
approved these changes
Nov 18, 2025
diasbruno
approved these changes
Nov 18, 2025
Contributor
Author
|
Is there anything blocking this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a define for this helps avoid security and other issues that can appear when using magic numbers.
This mimics the behaviour seen in other libraries like Olivier Gay's excellent SHA-2 library.