add event handler for frontend#2
Open
clifforum wants to merge 2 commits into
Open
Conversation
| dispatchPurviewEvent({ type: 'websocket:close', detail: { retries: state.numRetries } }); | ||
|
|
||
| if (state.numRetries === MAX_RETRIES) { | ||
| location.reload() |
There was a problem hiding this comment.
I'd also consider adding a log event here too, so we have a record of the refresh 😎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because we dont have visibility on FE side flow for the purview FE.
I added this events system, so in the orum code, we could add listeners to the different events and log metrics accordingly.
Basically so we could track the connection attempts, failures and successes.
In orum code we will need to add custom js code that will listen to events like this: