Draft
Conversation
bpow
force-pushed
the
website-integration
branch
4 times, most recently
from
aaf8737 to
6229eb4
Compare
…description original commit was modified by bpow to remove extraneous file changes in configs.json and groups.php, replace "magic numbers" with meaningful constants, and to not bump message version to 2.0 quite yet
* not needed for status since group_status is specified as NOT NULL and foreign key, so should always be present. I'd rather see an error than have it silently produce an empty value * use null-safe dereference rather than optional for parent_group. This is considered by many to be easier to read, and as it was written (with "->name" outside of the parentheses, I don't think it would have worked for all of the null-possible cases as it was written, anyway (if there was no parent group, then `optional($this->group->parentGroup)` would give an optional with null value, so we'd get an error when trying to access ->name from that
…vent has several TODOs for cleanup: - removing usused/commented code - possibly move membership description up to IsPublishableApplicationEvent - double-check display_name
…as often used for GroupEvents
… overloaded "application")
(since there is no formal approval process for WGs)
data, e.g., from CDWGs and AWGs are needed for website. For EPs, still don't publish until approved. Non-EPs have no approval process, so can just publish as soon as created. IMPORTANT: need to check on impact for CGSP-800 before moving to production.
there was already a parent BelongsTo...
bpow
force-pushed
the
website-integration
branch
from
6229eb4 to
644e362
Compare
bpow
force-pushed
the
main
branch
2 times, most recently
from
dcb54b0 to
4e01838
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of multiple CGSP tickets, replacing #86 so the commits there could be rebased/rewritten for clarity.