Skip to content

Bugfix crashes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpap wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix crashes #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47fc0f
Fix Marshal error for asn1 by passing struct, not pointer to struct.
jpap Sep 22, 2020
10235df
Fix for crash when HTTP client connection fails.
jpap Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func NewClient(url string) *Client {
// This will not verify the response. It is the caller's responsibility
// to call resp.Verify() on the returned TimeStampResp.
func (client *Client) Do(tsq *TimeStampReq) (*TimeStampResp, error) {
der, err := asn1.Marshal(tsq)
der, err := asn1.Marshal(*tsq)
if err != nil {
return nil, err
}
Expand All @@ -44,10 +44,10 @@ func (client *Client) Do(tsq *TimeStampReq) (*TimeStampResp, error) {
req.Header.Set("Content-Type", "application/timestamp-query")

resp, err := client.HTTPClient.Do(req)
defer resp.Body.Close()
if err != nil {
return nil, err
}
defer resp.Body.Close()

body, err := ioutil.ReadAll(resp.Body)
if err != nil {
Expand Down