Fix test failure in fresh checkout of repository #4056
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change import from 'spacetimedb' to '../src' to match other test files. This fixes the test failing to resolve the package entry.
douglance
changed the title
douglance
changed the title
Collaborator
|
Hey @douglance, thank you for taking the time to make a contribution! To minimize noise in the repo, we generally try to avoid small preference-inspired PRs (unless they're specifically bringing us in line with our linter, style guide, etc.) I hope that's understandable. Please let me know if I've missed something important about the motivation or impact here! |
Author
|
@bfops This fixes an issue where the tests fail unless the system has been built. It's not a preference thing. I lost some time trying to figure out why this test was failing on a fresh pull down of the repo. |
douglance
changed the title
Collaborator
|
Ah got it, thank you! That makes sense. |
bfops
approved these changes
Jan 21, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
LGTM if this fixes failures!
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use relative import
'../src'in serde.test.ts to match all other test files.This is a consistency fix. The
'spacetimedb'import works in CI (build runs first, enabling package self-reference), but all other tests use'../src'.API and ABI breaking changes
None
Expected complexity level and risk
1