feat: create Svelte framework integration #4063
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockwork-tien
force-pushed
the
tien/feat/svelte-integration
branch
from
398befc to
0124d6e
Compare
| } | ||
| } | ||
|
|
||
| function formatValue(v: Value): string { |
Contributor
There was a problem hiding this comment.
Much of this code is duplicated across Vue, React, Svelte. Can we please consolidate it into a shared file?
| import { useSpacetimeDB, useTable, useReducer } from 'spacetimedb/svelte'; | ||
| import { tables, reducers } from './module_bindings'; | ||
| const conn = useSpacetimeDB(); |
Contributor
There was a problem hiding this comment.
Is this idiomatic for Svelte? See: https://discord.com/channels/@me/1414626136121676017/1463374453193834506
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
This generally looks good to me. Just two questions/comments in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The PR implements the following updates:
svelte-tstemplateScreenshots
svelte-tstemplateAPI and ABI breaking changes
Expected complexity level and risk
Testing