Skip to content

Conversation

@cloutiertyler
Copy link
Contributor

@cloutiertyler cloutiertyler commented Jan 20, 2026

Description of Changes

When --yes is passed to spacetime dev, the flag is now also passed through to the internal spacetime generate call. This ensures that generate skips its interactive prompts when running in non-interactive mode.

API and ABI breaking changes

None.

Expected complexity level and risk

1 - Trivial change. Adds a conditional argument to an internal command invocation.

Testing

  • Run spacetime dev --yes and verify generate does not prompt for confirmation
  • Run spacetime dev (without --yes) and verify generate still prompts as expected

When --yes is passed to `spacetime dev`, now also pass it through to the
internal `spacetime generate` call so that generate skips its interactive
prompts as well.
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't work:

boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime dev --yes

thread 'main' panicked at /home/boppy/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.50/src/parser/matches/arg_matches.rs:185:17:
arg `yes`'s `ArgAction` should be one of `SetTrue`, `SetFalse` which should provide a default
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime dev

thread 'main' panicked at /home/boppy/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.50/src/parser/matches/arg_matches.rs:185:17:
arg `yes`'s `ArgAction` should be one of `SetTrue`, `SetFalse` which should provide a default
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
boppy@geralt:~/clockwork/quickstart-chat-rust$ which spacetime
/home/boppy/.local/bin/spacetime
boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime --version
spacetime Path: /home/boppy/.local/share/spacetime/bin/1.11.3-source/spacetimedb-cli
Commit: ab913fd8921ba8bda3a59ebb464f630729b8df1d
spacetimedb tool version 1.11.3; spacetimedb-lib version 1.11.3;

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like someone to double check my work but I do believe I've fixed the issue. Tested by me in WSL.

@cloutiertyler
Copy link
Contributor Author

Yes, force is the correct variable here.

@cloutiertyler cloutiertyler added this pull request to the merge queue Jan 21, 2026
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2026
@bfops bfops added this pull request to the merge queue Jan 21, 2026
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 21, 2026
@bfops bfops added this pull request to the merge queue Jan 21, 2026
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 21, 2026
@bfops bfops added this pull request to the merge queue Jan 21, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spacetime dev does not pass --yes option to generate command, causing it to get stuck if prompted to remove files

3 participants