-
Notifications
You must be signed in to change notification settings - Fork 673
Pass --yes flag from dev command to generate command #4069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When --yes is passed to `spacetime dev`, now also pass it through to the internal `spacetime generate` call so that generate skips its interactive prompts as well.
4de3ef7 to
ab913fd
Compare
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't work:
boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime dev --yes
thread 'main' panicked at /home/boppy/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.50/src/parser/matches/arg_matches.rs:185:17:
arg `yes`'s `ArgAction` should be one of `SetTrue`, `SetFalse` which should provide a default
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime dev
thread 'main' panicked at /home/boppy/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/clap_builder-4.5.50/src/parser/matches/arg_matches.rs:185:17:
arg `yes`'s `ArgAction` should be one of `SetTrue`, `SetFalse` which should provide a default
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
boppy@geralt:~/clockwork/quickstart-chat-rust$ which spacetime
/home/boppy/.local/bin/spacetime
boppy@geralt:~/clockwork/quickstart-chat-rust$ spacetime --version
spacetime Path: /home/boppy/.local/share/spacetime/bin/1.11.3-source/spacetimedb-cli
Commit: ab913fd8921ba8bda3a59ebb464f630729b8df1d
spacetimedb tool version 1.11.3; spacetimedb-lib version 1.11.3;
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like someone to double check my work but I do believe I've fixed the issue. Tested by me in WSL.
|
Yes, force is the correct variable here. |
Description of Changes
When
--yesis passed tospacetime dev, the flag is now also passed through to the internalspacetime generatecall. This ensures that generate skips its interactive prompts when running in non-interactive mode.API and ABI breaking changes
None.
Expected complexity level and risk
1 - Trivial change. Adds a conditional argument to an internal command invocation.
Testing
spacetime dev --yesand verify generate does not prompt for confirmationspacetime dev(without --yes) and verify generate still prompts as expected