-
Notifications
You must be signed in to change notification settings - Fork 673
Small docs improvement #4071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tyler/claude-docs-5
Are you sure you want to change the base?
Small docs improvement #4071
Conversation
b0732c8 to
721eae2
Compare
… non-persistent Explains the multiple reasons why relying on module-level state is undefined: fresh instances, module updates, concurrent execution, crash recovery, non-transactional updates, and replay safety.
- Change generate output path from ../client-unity/Assets/autogen to ../Assets/autogen - Fix Rust directory references from server-rust to spacetimedb to match what spacetime init creates
- Update inline storage recommendations to reflect ~100MB capability - Add pricing context ($1/GB) for choosing between inline and external storage - Fix Unity tutorial generate command path (../Assets/autogen not ../client-unity/Assets/autogen) - Fix Rust directory references from server-rust to spacetimedb
Strip volatile fields that change every run: - Timestamps (started_at, finished_at) - Local paths (work_dir_golden, work_dir_llm) - Temp database names (golden_db, llm_db) - Server port numbers from scorer notes Also clear llm_output for passing tests (keep for failures for debugging).
Add documentation for calling between reducers and procedures: - Add "Calling Reducers from Procedures" section showing how to invoke reducer functions within withTx blocks - Add "Scheduling Procedures" section explaining how reducers can schedule procedures via schedule tables - Add tip to schedule-tables.md clarifying procedure scheduling
- Wrap code snippets inside reducer functions - Fix TypeScript: ctx.timestamp.microseconds → ctx.timestamp.microsSinceUnixEpoch - Fix Rust: use std::time::Duration instead of spacetimedb::Duration All examples verified to compile in TypeScript, Rust, and C#.
Add note explaining that the `pub` modifier on Rust table structs follows normal Rust visibility rules and has no effect on SpacetimeDB client visibility.
- Add "Uploading to S3 from a Procedure" section to file-storage docs - Add "Pre-signed URL Flow" alternative pattern - Replace all "C# procedures coming soon" with working examples - Update procedures.md, reducers.md, access-permissions.md, cheat-sheet.md All code examples verified to compile in TypeScript, Rust, and C#.
3647340 to
be2046e
Compare
|
/update-llm-benchmark |
LLM Benchmark Results (ci-quickfix)
Compared against master branch baseline Generated at: 2026-01-21T14:48:14.116Z Failure Analysis (click to expand)Benchmark Failure AnalysisGenerated from: Summary
SpacetimeDB Benchmark AnalysisRust / rustdoc_json FailuresCompile/Publish Errors (2 failures)t_002_scheduled_table & t_017_scheduled_columns
Other Failures (6 failures)1. t_003_struct_in_table
2. t_013_spacetime_sum_type
3. t_015_product_type_columns
SummaryAcross the variations of failures, common issues arise from:
Next Steps: Immediate updates to the documentation should reflect these observations, improving clarity and usability for developers. |
- Add crash recovery implementation details (4096 batch size, 128-bit counter) - Add multi-language examples for crash recovery behavior - Update link in transactions-atomicity.md to point to auto-increment page - Remove appendix.md as its only content is now in auto-increment.md
Description of Changes
Two documentation improvements:
Reducers documentation: Clarified that using global/static variables in reducers is undefined behavior, not just "values won't persist". Added six specific reasons why this is undefined:
Access permissions documentation: Replaced the "Combining Both Techniques" example that used indexes on Option fields (which SpacetimeDB doesn't support) with a working example that filters by a required
departmentfield instead.API and ABI breaking changes
None. Documentation only.
Expected complexity level and risk
1 - Documentation changes only.
Testing