docs(code-review): correct stale prefix-harness "Phase 4b" comments - #177
Merged
Merged
Conversation
PLN-1229 delivered the deterministic-prefix golden harness (prefix_golden_harness.py) and its subprocess A/B parity oracle, but two docstrings and the SCHEMA.md golden-fixture section still described that work as a future "Phase 4b" that "will extend" the post-collection harness. Update golden_fixture_harness.py, the cmd_prepare_run docstring, and SCHEMA.md section 12 to point at the delivered harness and note the orchestrator now runs the deterministic prefix in-process via run-prefix rather than walking those stages one at a time. Docs-only; bump 3.4.0 -> 3.4.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Docs-only cleanup closing out PLN-1229 (in-process
run-prefixbatch runner). PLN-1229 delivered the deterministic-prefix golden harness (prefix_golden_harness.py) and its subprocess A/B parity oracle, but three spots still described that work as an unbuilt future "Phase 4b" that "will extend" the post-collection harness:golden_fixture_harness.pydocstringprefix_golden_harness.py+ parity oraclecmd_prepare_rundocstring (code_review_helpers.py)run-prefix… and walks the reviewer tail stage-by-stage"SCHEMA.md§12 (golden fixture harness)Left untouched: the accurate historical labels (
prefix_golden_harness.py's own docstring already says Phase 4b "was never built. This module builds it"; thestart.md§header and a test docstring are attribution, not false claims), and the unrelated genuine deferrals (_DEFERRED_FIXTURESgated on plans 03/05/06; cross-run analytics).Why
Surfaced by a cleanup audit before closing FEA-2385. Leaving future-tense "will extend" comments for work that's already merged is exactly the stale-comment drift the repo guards against — and the plan itself quoted one of these comments as its motivation.
Validation
will extend/Phase 4b willclaims remain (grep clean).ruff checkclean on both changed.pyfiles.3.4.0 → 3.4.1(PATCH).🤖 Generated with Claude Code