fix(code-review): revert #178 parallel GitHub fleet → restore synchronous headless dispatch (FEA-3085) - #179
Merged
Conversation
…ous headless dispatch (FEA-3085) Reverts d7362f0 (v3.5.0, #178) and bumps 3.4.1 -> 3.6.0. #178 unified GitHub and local reviewer-fleet dispatch (stage_20) on run_in_background: true + blocking TaskOutput, on the premise that headless `claude -p` (Claude Code >= v2.1.182) reliably awaits background subagents as long as the orchestrator issues the blocking collection. Empirically the orchestrator does NOT reliably issue it. In ~18% of symphony-alpha claude-code-review.yml pull_request runs on 2026-07-13 (9/50, up from 1/10 the day #178 went live) it launched the fleet (Bug Hunter A/B, Unified Auditor) as background agents and then ended its turn ('I'll wait for the harness to notify me') with no pending synchronous tool call, so claude -p exited (terminal_reason: completed) before stage_21_collect_findings..stage_30_footer ran. No findings were collected, no .closedloop-ai/code-review-* artifacts were written, and the workflow's 'Validate migrated review artifacts' guard failed the job. Runs that took the synchronous fast-path branch were unaffected, which is why the failure was intermittent. Restore the known-good split: GitHub/headless standard flow dispatches reviewers synchronously one-at-a-time (run_in_background: false, wait for each 'DONE findings=N file=...' before the next), which keeps the turn alive by construction rather than depending on the model choosing to issue a blocking TaskOutput; local mode keeps parallel background dispatch + blocking TaskOutput. Restores the FEA-2162 synchronous-GitHub reviewer contract and its test class. Trade-off: GitHub review wall-clock returns to sum-of-reviewers -- correctness over speed for a merge-adjacent gate. Full code-review suite green (2079 passed, 3 skipped), ruff + pyright clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mikeangstadt
approved these changes
Jul 14, 2026
mikeangstadt
left a comment
Collaborator
There was a problem hiding this comment.
Sound revert. Restores the sync GitHub dispatch that we know keeps the headless turn alive, and the version bump + tests line up. One real question about whether the verifier fleet has the same headless death you're fixing here, plus a changelog nit. Not blocking either.
…t (not replace) Address review: v3.5.0 shipped to main, so its changelog block must stay (entries are newest-first + treated as released on merge). Put v3.6.0 on top of the retained v3.5.0 Changed block instead of deleting it. Also note in v3.6.0 that stage_23 verifiers are unchanged and their headless exposure is tracked in FEA-3154. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #178 (
code-reviewv3.5.0) and bumps 3.4.1 → 3.6.0, restoring synchronous reviewer-fleet dispatch for GitHub/headless mode atstage_20_spawn_reviewers. Local mode keeps parallel background dispatch + blockingTaskOutput.#178 unified both modes on
run_in_background: true+ blockingTaskOutput, betting that headlessclaude -p(Claude Code ≥ v2.1.182) reliably awaits background subagents as long as the orchestrator issues the blocking collection. Empirically it does not: in ~18% ofsymphony-alphaclaude-code-review.ymlpull_requestruns on 2026-07-13 (9/50, up from 1/10 the day #178 shipped) the orchestrator launched the reviewer fleet (Bug Hunter A/B, Unified Auditor) as background agents and then ended its turn ("I'll wait for the harness to notify me") with no pending synchronous tool call.claude -pthen exited (terminal_reason: "completed") beforestage_21_collect_findings … stage_30_footerran — no findings collected, no.closedloop-ai/code-review-*artifacts written, and the workflow's "Validate migrated review artifacts" guard failed the job. Runs that took the synchronous fast-path were unaffected, hence the intermittency.Synchronous one-at-a-time dispatch (
run_in_background: false, wait for eachDONE findings=N file=...before the next) keeps the headless turn alive by construction, rather than depending on the model choosing to issue a blockingTaskOutput. This restores the exact pre-#178 state that ran reliably (the verifier fleet atstage_23was already background+collect in both modes before #178 and is unchanged).Trade-off: GitHub review wall-clock returns to sum-of-reviewers instead of slowest-reviewer. Correctness over speed for a merge-adjacent gate.
Root-cause detail and the 9 failing run IDs are tracked in FEA-3085.
Feature Flags
N/A — plugin behavior change, no runtime flag.
Breaking changes
None. Restores prior GitHub-mode dispatch semantics; output contract and artifacts unchanged.
Test plan
uv run --frozen --group dev pytest→ 2079 passed, 3 skippedruff check .→ cleanpyright→ 0 errors, 0 warningssymphony-alphaclaude-code-review.ymlpull_requestruns for the artifact-validation failure signature (expect it to clear once CI pulls v3.6.0).🤖 Generated with Claude Code