This repository was archived by the owner on Jun 8, 2026. It is now read-only.
PERF: Paginate design dashboard sessions - #276
Merged
Merged
Conversation
- Add bounded session page and single-session detail database reads - Move sessions list, Kanban, and detail views off all-session detail loads - Add pagination regression coverage and bump desktop version Testing: desktop lint, desktop typecheck, and focused session pagination test passed Risks: Full desktop test suite was rerun after regenerating legacy agent-monitor output but was still in progress when requested to push
Compatibility Smoke Test Results
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1565215eef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add a server-side running filter that excludes sessions awaiting input - Point the Kanban running column at the non-waiting filter - Cover running versus waiting pagination semantics Testing: desktop lint, desktop typecheck, and focused session pagination test passed Risks: Low; filter change is scoped to the new paginated session API
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
Contributor
|
I do not see the four claimed fixes on the current PR head yet. The remote PR ref is still |
…al index, loading reset - Add s.id DESC tiebreaker to active sessions query for deterministic ordering - Escape underscore in model LIKE pattern with ESCAPE backslash - Add idx_sessions_running_started_at partial index for active sessions filter - Reset loading=true on query key change before fetch Testing: typecheck and lint pass
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
mikeangstadt
commented
Jun 7, 2026
…g, debounce - Renumber schema migration to v7 (v6 claimed by PR #274 FEA-1548) - Restore CTE-based joins for unbounded active/historical detail queries; keep correlated subqueries only for bounded getPage/getDetailsById - Cache prepared statements for dynamic page queries via getOrPrepare() - Add getKanbanPages() single-IPC batch method replacing 5 parallel calls - Add 300ms debounce on SessionsView search input - Bump version 0.15.115 → 0.15.116 - Add tests: LIKE wildcard escape, tied-timestamp pagination, kanban batch Testing: 6/6 pagination tests pass, typecheck clean. Risks: CTE restoration changes the query plan for active/historical paths back to the pre-PR pattern — same behavior, proven safe on the 7 GB DB. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
The 1st pass of review resolutions didn't push it's fixes properly; this is adjusted now. |
- Align identity-column migration tests with the current schema version so PR merge commits do not fail when later migrations exist. Testing: Focused session identity migration test and desktop typecheck passed. Risks: Low; test-only assertion update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
just desktop-lintjust desktop-typecheck./apps/desktop/node_modules/.bin/tsx --test apps/desktop/test/agent-session-pagination.test.tsjust desktop-testNotes