This repository was archived by the owner on Jun 8, 2026. It is now read-only.
FEA-1564: Backdate backfill timestamps - #277
Merged
Merged
Conversation
- Use latest source transcript timestamps for backfilled sessions, agents, events, and token usage. - Keep copied historical transcripts from being marked active based on file mtime alone. - Add regression coverage for source-dated backfill windows and missing event timestamps. Testing: Full desktop test suite, typecheck, lint, and focused collector import tests passed. Risks: Existing incorrectly dated local rows are not migrated; future imports are corrected.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03a5103e91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
shafty023
reviewed
Jun 6, 2026
…imestamps - Guard isRecentlyActive against future sourceUpdatedAt timestamps - Use progressive synthetic timestamps for no-timestamp events to avoid high-water-mark dedup collisions - Already committed: updated_at coalesce for nameless events Testing: typecheck and lint pass
- Keep sessions.updated_at as an ingest-time sync cursor while preserving source dates for analytics. - Touch existing sessions only when new backfill events are appended or a row is reactivated. - Cover future source timestamps and appended no-timestamp event imports. Testing: Focused collector import tests, desktop typecheck, desktop lint, and full desktop test suite passed. Risks: Token usage updated_at remains source-dated because token analytics use token_usage.created_at and session sync is driven by sessions.updated_at.
# Conflicts: # apps/desktop/src/main/collectors/import-session.ts
- Bump desktop package version for the backfill timestamp PR. Testing: Not run; package metadata-only change. Risks: Low; release metadata-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Artifact Links
Testing
Risks