Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

FEA-1564: Backdate backfill timestamps - #277

Merged
mikeangstadt merged 5 commits into
mainfrom
fix-backfill-source-timestamps
Jun 7, 2026
Merged

FEA-1564: Backdate backfill timestamps#277
mikeangstadt merged 5 commits into
mainfrom
fix-backfill-source-timestamps

Conversation

@mikeangstadt

@mikeangstadt mikeangstadt commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Backdate backfill-written session, agent, event, and token usage timestamps to the latest source transcript timestamp instead of importer runtime.
  • Keep copied historical transcripts from being treated as active based on file mtime alone; source activity must also be recent.
  • Add regression coverage for historical backfill date windows and missing source event timestamps.
  • Bump desktop to 0.15.115.

Artifact Links

Testing

  • just desktop-lint
  • just desktop-typecheck
  • ./apps/desktop/node_modules/.bin/tsx --test apps/desktop/test/collectors-import.test.ts
  • just desktop-test

Risks

  • Existing incorrectly dated local rows are not migrated by this change; future imports are corrected.

- Use latest source transcript timestamps for backfilled sessions, agents, events, and token usage.

- Keep copied historical transcripts from being marked active based on file mtime alone.

- Add regression coverage for source-dated backfill windows and missing event timestamps.

Testing: Full desktop test suite, typecheck, lint, and focused collector import tests passed.

Risks: Existing incorrectly dated local rows are not migrated; future imports are corrected.
@mikeangstadt
mikeangstadt requested a review from a team June 6, 2026 16:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03a5103e91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/src/main/collectors/import-session.ts Outdated
Comment thread apps/desktop/src/main/collectors/import-session.ts Outdated
Comment thread apps/desktop/src/main/collectors/import-session.ts
Comment thread apps/desktop/src/main/collectors/import-session.ts Outdated
@mikeangstadt mikeangstadt changed the title FEAT: Backdate backfill timestamps FEA-1564: Backdate backfill timestamps Jun 6, 2026
…imestamps

- Guard isRecentlyActive against future sourceUpdatedAt timestamps
- Use progressive synthetic timestamps for no-timestamp events to avoid
  high-water-mark dedup collisions
- Already committed: updated_at coalesce for nameless events

Testing: typecheck and lint pass
- Keep sessions.updated_at as an ingest-time sync cursor while preserving source dates for analytics.

- Touch existing sessions only when new backfill events are appended or a row is reactivated.

- Cover future source timestamps and appended no-timestamp event imports.

Testing: Focused collector import tests, desktop typecheck, desktop lint, and full desktop test suite passed.

Risks: Token usage updated_at remains source-dated because token analytics use token_usage.created_at and session sync is driven by sessions.updated_at.
@mikeangstadt
mikeangstadt requested a review from shafty023 June 7, 2026 21:03
# Conflicts:
#	apps/desktop/src/main/collectors/import-session.ts
- Bump desktop package version for the backfill timestamp PR.

Testing: Not run; package metadata-only change.

Risks: Low; release metadata-only change.
@mikeangstadt
mikeangstadt merged commit 013df19 into main Jun 7, 2026
5 checks passed
@mikeangstadt
mikeangstadt deleted the fix-backfill-source-timestamps branch June 7, 2026 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants