This repository was archived by the owner on Jun 8, 2026. It is now read-only.
PLN-821: Ungate local dashboard import from sandbox scoping - #278
Merged
Conversation
- Remove gate() method and isSessionInSandbox check from CollectorManager so all five harness collectors import sessions into agent-dashboard.sqlite regardless of sandbox directory - Remove isSessionInSandbox sandbox check from AgentHookListener handleHookEvent() so hook events write to local DB ungated - Remove getSandboxBaseDirectory from CollectorManagerOptions, AgentHookListenerOptions, and AgentDashboardDesignSystemRuntimeOptions - Preserve sandbox enforcement on cloud-sync path in AgentSessionSyncService (unchanged) - Update tests to assert all sessions import regardless of sandbox - Add regression test confirming sync-service sandbox filter preserved - Bump desktop version to 0.15.117 Testing: Ran just desktop-test (2180/2181 pass, 1 pre-existing failure). Ran specific test files (18/18 pass). Verified typecheck and lint failures are pre-existing in untracked files. Risks: More sessions will be written to local DB (intended behavior). Cloud sync path unchanged — outbound data still sandbox-gated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7cb10eaef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-dashboard.sqliteregardless of the configured sandbox directoryAgentSessionSyncServiceto maintain data-egress safetyChanges
collector-manager.ts— Removedgate()method,isSessionInSandboximport, andgetSandboxBaseDirectoryoptionagent-monitor-listener.ts— RemovedisSessionInSandboxsandbox check fromhandleHookEvent()andgetSandboxBaseDirectoryoptionagent-dashboard-design-system-runtime.ts— RemovedgetSandboxBaseDirectoryfrom options interface and pass-throughapp.ts— RemovedgetSandboxBaseDirectoryfrom runtime constructor callTest plan
isSessionInSandboxfilter remains activejust desktop-testpasses (2180/2181, 1 pre-existing failure inno-bare-console.test.ts)🤖 Generated with Claude Code