This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Conversation
- Add GatewayLogger class with info/warn/error/debug levels and in-memory ring buffer (500 entries) for UI display - Add structured logging to Socket.IO lifecycle (connect, disconnect, auth errors, hello ack, hello timeout) - Add logging to cloud command executor (enqueue, execute, gateway HTTP errors, timeout, failure) - Add logging to symphony loop harness (request source relay/local, process spawn, exit code, event POST errors, artifact upload errors) - Split logging: lifecycle events and errors always visible, granular per-step details gated behind verbose toggle - Suppress consecutive identical log messages (dedup presence spam) - Add Diagnostics tab with auto-refresh, verbose toggle, and color-coded error/warn row highlighting - Rename Activity Log tab to Requests for clarity - Add verboseLogging to DesktopSettings with persistence Testing: - just desktop-typecheck passes - just desktop-test passes (288/288) - just desktop-lint passes Risks: - Logging adds minor overhead to hot paths (suppressed by dedup) - In-memory buffer capped at 500 entries, no disk persistence
Code Review SummaryStatus: Approved Reviewers: Bug Hunter A, Bug Hunter B, Unified Auditor, Premise Reviewer, Cloud Command Executor Specialist Findings
MEDIUM Issues (consider)
Validation Stats
Recommendation: Approve. No blocking or high issues. The clear()/lastMessage bug and scroll-lock UX are the most impactful medium items. |
- Reset lastMessage on clear() so first post-clear log is not dropped - Pass copy (not mutable ref) from clear() onChange callback - Remove unused LOG_LEVEL_COLORS constant - Escape e.tag in log row innerHTML to prevent XSS - Only auto-scroll to bottom if user was already at bottom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing:
Risks: