This repository was archived by the owner on Jun 8, 2026. It is now read-only.
Conversation
mikeangstadt
approved these changes
Mar 26, 2026
- Rewrite before-quit handler to call event.preventDefault(), run async shutdown, then app.exit() to guarantee termination - Extract ShutdownDeps interface and runShutdownSequence() into new shutdown.ts with 5s timeout and injectable timer for tests - Change shutdown() in app.ts to delegate to runShutdownSequence and return "clean", "timed_out", or "failed" result - Add shutdown.test.ts covering clean, timeout, failed, and timer cleanup paths - Bump version 0.8.9 -> 0.8.10 Testing: All 432 tests pass, lint clean, typecheck clean Risks: app.exit() skips Electron window cleanup events, but we already clean up everything in shutdown(); strictly better than the current behavior where the process never exits
- Remove pull_request and pull_request_target triggers from claude-code-review workflow until org secrets are configured for the now-public repo - Workflow can still be run manually via workflow_dispatch Testing: Verified workflow file is valid YAML Risks: No automated code reviews on new PRs until re-enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: All 432 tests pass, lint clean, typecheck clean Risks: app.exit() skips Electron window cleanup events, but we already clean up everything in shutdown(); strictly better than the current behavior where the process never exits