Skip to content

feat(gitlab): add builtin admin roles to GitLab#1899

Draft
shikanime wants to merge 3 commits intomainfrom
pr1899
Draft

feat(gitlab): add builtin admin roles to GitLab#1899
shikanime wants to merge 3 commits intomainfrom
pr1899

Conversation

@shikanime
Copy link
Contributor

@shikanime shikanime commented Feb 5, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 Hey !

The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 Hey !

The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 Hey !

The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 Hey !

The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

StephaneTrebel
StephaneTrebel previously approved these changes Feb 6, 2026
@cloud-pi-native-sonarqube
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

…loack

The new AdminRole implementation introduced by #1893 changed the source of truth from Keycloak to Console, which overrides all existing data based on the state of Console.

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@shikanime shikanime force-pushed the pr1899 branch 2 times, most recently from 3037e56 to fa47938 Compare February 6, 2026 15:43
The implementation of ProjectRole is slightly different from AdminRole in which the members are stored around Project struture. I didn't took account of this difference in #1880 and #1879 leading to member addition to never materialize.

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants