Conversation
While /usr/bin/java might exist on users macOS system, when no JDK or JRE is installed, it typically act as a placeholder or symlink meant to guide users toward installing Java. So in such case, when we call `java -version` it return an error instead of the version, which we need to handle.
Updated the check_java_version function to return -1. Even if the 'java' command exists, if the 'java -version' command returns non-zero value, we can safely assume that java is not installed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR addresses the following error:
While
/usr/bin/javamight exist on users macOS system, when no JDK or JRE is installed, it typically act as a placeholder or symlink meant to guide users toward installing Java. So in such case, when we calljava -versionin our code, as the command returns an non-zero error code instead of the version, we need to handle it.New behavior: