Conversation
Python side of the change that pairs up with the Java change earlier in the history. The notion of "repository name" is already present in `record build`, so that change is straighforward. `record commit` needs a new option and sensible default.
|
kohsuke
changed the title
Contributor
Author
|
Actually, capturing the repository name creates a complexity on the server side to match test names to file names that I don't want to deal with right now. |
Contributor
Author
|
Either intentionally or unintentionally, I have already merged all the commits in this branch except for the last one which is for the Python side. Without this commit in, Java side has the wrong repo name calculation, so might as well get this in, even though we aren't sending the repository name to the server. |
Konboi
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.