Conversation
Sending the entire git-ls-tree every time we record build is too time consuming. So I'm now combining both approaches I've done in the past. 1. CLI would use advertised refs to decide files that the server hasn't seen. This should narrow the list down to less than O(n) for the amount of changes "n" 2. We'll send those BLOB IDs to the server to further narrow down what we transfer. This way, if there's a large amount of file transfer involved (say, initial import) and it fails in the middle, the next invocation will not attempt to send all the files all over again.
takanabe
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the internal project write-up for more details.