[AIENG-196] Add the new command for the early flake detection#1130
Merged
[AIENG-196] Add the new command for the early flake detection#1130
Conversation
42f60a7 to
41ef690
Compare
41ef690 to
31b5f27
Compare
This comment has been minimized.
This comment has been minimized.
de80e7c to
072ca6c
Compare
gayanW
approved these changes
Sep 10, 2025
gayanW
reviewed
Sep 10, 2025
| split_subset = launchable.CommonSplitSubsetImpls(__name__, | ||
| formatter=lambda x: x[0]['name'] + ":" + x[1]['name']).split_subset() | ||
|
|
||
| launchable.CommonFlakeDetectionImpls(__name__, formatter=lambda x: x[0]['name'] + ":" + x[1]['name']).flake_detection() |
Contributor
There was a problem hiding this comment.
For my information:
Why do we need it here?
Contributor
Author
There was a problem hiding this comment.
To register this test runner as the command. By adding that line, we can do something like this:
$ launchable retry flake-detection --session 'builds/210/test_sessions/289' --confidence low bazel
Contributor
|
FYI: |
Contributor
Author
Oh, good catch. Thanks! |
Konboi
added a commit
that referenced
this pull request
Sep 22, 2025
Konboi
added a commit
that referenced
this pull request
Sep 22, 2025
to align v2 command option formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.