Conversation
This comment has been minimized.
This comment has been minimized.
ono-max
commented
Sep 16, 2025
| # /error is an actual endpoint that exists on our service to test the behavior | ||
| res = cli.request("GET", "intake/error") | ||
| # /raise_error is an actual endpoint that exists on our service to test the behavior | ||
| res = cli.request("GET", "intake/raise_error") |
Contributor
Author
There was a problem hiding this comment.
FYI: Updated this endpoint because you modified the endpoint on the intake side.
Contributor
There was a problem hiding this comment.
I think this test is meaningless.
Please remove this test case
gayanW
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.